Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable mechanism for manually setting static event loop to use for new handles (see #2450) #2684

Merged
merged 2 commits into from Sep 1, 2021

Conversation

lminiero
Copy link
Member

@lminiero lminiero commented Jun 4, 2021

Same as #2450, but for master. Please refer to that PR for more info.
I don't have time to test. If you care about this, please provide feedback.

@fancycode
Copy link
Contributor

Thanks, would it be possible to include this setting in the "info" object, similar to what is already done with static-event-loops?

json_object_set_new(info, "static-event-loops", json_integer(janus_ice_get_static_event_loops()));

That way, clients could detect if handles can be assigned to loops or not.

I'm happy to do a follow-up PR myself once this has landed.

@lminiero
Copy link
Member Author

Done (not tested).

@lminiero
Copy link
Member Author

Any update on this?

@lminiero
Copy link
Member Author

This has been around two months and I got no feedback. If I don't get any feedback on Monday, I'll close the PR, as I'll assume no one needs this anymore (we currently don't).

@fancycode
Copy link
Contributor

Sorry for not replying earlier, other things got in the way. This is working fine for us and improves CPU usage a little bit in some scenarios if we pin the subscribers to the same loop than the publisher is running on.

Thanks for splitting this up in a separate PR, would be great if you could merge it. Thanks!

@lminiero
Copy link
Member Author

lminiero commented Sep 1, 2021

Thanks for the feedback, and apologies for the late reply (just got back from vacation). Merging then 👍

@lminiero lminiero merged commit 641ee4e into master Sep 1, 2021
@lminiero lminiero deleted the loop-indication-bis branch September 1, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants