Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify recordings folder in AudioBridge #2707

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

lminiero
Copy link
Member

This extends the enable_recording feature added by @rajneeshksoni to the AudioBridge plugin in #2674, by adding an additional property, called record_dir, where you can specify where the .wav recordings should be stored. It's available both in room creation (API or jcfg file) and when using enable_recording: when provided, it makes record_file a relative path. Notice this only impacts .wav recordings, and not the individual recording via .mjr that we do support in the AudioBridge: it may make sense to enforce it for those too, but maybe later.

Tested briefly but it seems to be working for me, feedback welcome.

@rajneeshksoni
Copy link
Contributor

I like function with "record_dir" this makes it much easier to use.
I tested it and found a issue if during enable_recoding only "record_dir" is provided and "record_file" is not provided, API return success, record_dir directory is created but audio file is generated in the location where janus is launched.
so either api should return error or we should handle default file with user specified record_dir.

@lminiero
Copy link
Member Author

Good catch: record_dir with no record_file is definitely allowed, it must create the filename randomly using your code, but place it in that folder. I'll fix it shortly. Thanks for the feedback!

@lminiero
Copy link
Member Author

The commit above shoud fix it (haven't tested though).

@rajneeshksoni
Copy link
Contributor

Tested, now it is working fine.

@lminiero
Copy link
Member Author

Ack, merging then.

@lminiero lminiero merged commit 6d27a16 into master Jun 21, 2021
@lminiero lminiero deleted the audiobridge-recdir branch June 21, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants