Fix partial/broken ACL support in TextRoom plugin #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good day! |
|
Ack, thanks for confirming, I'll merge then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in a post on the group, the TextRoom plugin allows you to configure an ACL (Access Control List) via API, but then it has no way to enforce it. This is indeed a bug in the plugin, probably due to some copy/paste leftovers when we first implemented the feature for multiple plugins in #745.
This PR fixes this broken behaviour. Planning to merge soon, as soon as we have feedback that it works as expected, so if you're using the plugin you may want to double check it doesn't introduce regressions for you (it shouldn't).