Use prepend with reverse list in the sdp parsing (Credit to OSS-Fuzz) #2776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes after an oss-fuzz timeout report.
When parsing the SDP janus makes large use of
g_list_append
. Unfortunately this specific implementation needs to traverse the entire list for every append (ref. glib sources).As suggested by glib docs, we replaced the append with prepend + reverse operation in tail (so the list gets traversed only once).
The timeout is due to SDPs containing a lot of m-lines or attributes.