Remove gengetopt as a dependency, and use Glib's GOptionEntry instead #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this PR removes the need to have
gengetoptinstalled, when compiling Janus: we usedgengetoptas a helper application to generate our command line options and related parser (which would be generated automatically by the Makefile), but since Glib comes with a set of utilities usingGOptionEntry, I thought I'd change the code to use that instead.Nothing should change from a user perspective, since the command line options that existed before remain the same, and are activated the same way as well. Of course, some feedback to be sure I'm not breaking something in the process is more than welcome.