Fix getBitrate() #3340
Merged
Fix getBitrate() #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lminiero
reviewed
Mar 11, 2024
html/demos/janus.js
Outdated
| @@ -3045,7 +3045,7 @@ function Janus(gatewayCallbacks) { | |||
| return; | |||
| let inStats = false; | |||
| // Check if these are statistics on incoming media | |||
| if((res.mediaType === "video" || res.id.toLowerCase().indexOf("video") > -1) && | |||
| if((res.kind === "video" || res.id.toLowerCase().indexOf("video") > -1) && | |||
There was a problem hiding this comment.
Wouldn't it better to keep both? Like
res.mediaType === "video" || res.kind === "video" || ...
I just want to avoid scenarios where there's still older browsers that don't support the new syntax.
There was a problem hiding this comment.
Seems reasonable, I hope it won't be redundant as it was the only "mediaType" property used in the file.
|
Merging, thanks! |
lminiero
added a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since "mediaType" property seems deprecated as it was renamed to "kind" (https://developer.mozilla.org/en-US/docs/Web/API/RTCInboundRtpStreamStats), i would like to introduce small change in janus.js getBitrate function, so that it will return the correct values when called on iPhones and iPads