Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deploy] GitHub #7

Closed
redsox2002 opened this Issue Oct 18, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@redsox2002
Copy link

redsox2002 commented Oct 18, 2017

Service

This is a Franz plugin for GitHub.

Link to your repository

https://github.com/redsox2002/recipe-franz-github

@ldrrp

This comment has been minimized.

Copy link

ldrrp commented Oct 18, 2017

You can at least source me if your gonna take my readme word for word

@ldrrp

This comment has been minimized.

Copy link

ldrrp commented Oct 18, 2017

I also dont really see a good use for having it in a webview for franz IMO

@redsox2002

This comment has been minimized.

Copy link
Author

redsox2002 commented Oct 18, 2017

@ldrrp changed the README to no longer need your sourcing. 😂

@redsox2002

This comment has been minimized.

Copy link
Author

redsox2002 commented Oct 18, 2017

@ldrrp I disagree, GitHub is meant for collaboration and having the webview for Franz to quickly view PR's, comment on issues, etc can be helpful.

@ldrrp

This comment has been minimized.

Copy link

ldrrp commented Oct 19, 2017

I usually open multiple github tabs to review code and stuff, but i can see it being useful for chat like this. if only there was a friendlier view for stuff like this, otherwise your just navigating around lot to get to the stuff you need. Either way im not opposed to it at all seeing as its only going to be installed by the users who really want it. Since its not packaged with every install then who cares lol

@adlk

This comment has been minimized.

Copy link
Contributor

adlk commented Oct 19, 2017

I'm still a bit divided by what services to "allow", especially with the global repository in mind.
I think a categorization might make this a little easier as messaging services wouldn't be in one list with e.g github.

I'm going to push this soon, need to get other stuff done first.

@ldrrp

This comment has been minimized.

Copy link

ldrrp commented Oct 19, 2017

Yea that makes way more sense now. With that in mind. eclipse che could probably be one of those since its web driven. but idc for che, someone would have to do it seeing as its all a custom url / ip

@adlk

This comment has been minimized.

Copy link
Contributor

adlk commented Oct 23, 2017

Wouldn't it make sense to display the notifications as an indirect badge? Just food for thought for a future update.


Deployed, thanks for your contribution.

@adlk adlk closed this Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.