Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy testUtils from mocks repo into compenents repo #121

Merged
merged 2 commits into from
Mar 15, 2017

Conversation

sadafie
Copy link

@sadafie sadafie commented Mar 9, 2017

We want to minimize the number of dependencies that the meetup-web-mocks repo has, so we're going to have each consumer repo maintain it's own testUtils.jsx.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.276% when pulling 32211d9 on feature/testUtils into 934d6e0 on master.

@eilinora
Copy link

eilinora commented Mar 9, 2017

is mocks repo going away?

@sadafie
Copy link
Author

sadafie commented Mar 9, 2017

No it's not. We're trying to pair it down to a zero-depedenc repo, so it's just the JS files for the mocks and nothing else. It's just a simplification / optimization, so we don't have so many dependencies updating across as many repos.

@sadafie sadafie requested a review from mmcgahan March 10, 2017 14:48
Copy link
Contributor

@mmcgahan mmcgahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be easier long-term to leave testUtils.js out of this repo and just use scryRenderedComponentsWithType() instead - it requires a small refactor, but it's worth it in order to use the more 'standard' test utilities and keep the repo simpler

@sadafie
Copy link
Author

sadafie commented Mar 13, 2017

I think it will be easier long-term to leave testUtils.js out of this repo and just use scryRenderedComponentsWithType() instead

done

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.276% when pulling 1ba6cc0 on feature/testUtils into 934d6e0 on master.

@sadafie sadafie merged commit cfc82d4 into master Mar 15, 2017
@chenrui333 chenrui333 deleted the feature/testUtils branch September 16, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants