Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sds 212/fix at all flex classes #130

Merged
merged 3 commits into from
Mar 15, 2017
Merged

Sds 212/fix at all flex classes #130

merged 3 commits into from
Mar 15, 2017

Conversation

akdetrick
Copy link
Contributor

Related issues

Fixes https://meetup.atlassian.net/browse/SDS-212

Description

Update swarm-sasstools to get updated signature for _bpModifier that allows us to generate "atAll" breakpoint classes.

See also: https://github.com/meetup/swarm-sasstools/blob/master/scss/utils/helpers/_pcv-modifier.scss#L54

@akdetrick akdetrick added the bug label Mar 15, 2017
@akdetrick akdetrick requested a review from eilinora March 15, 2017 20:49
@eilinora
Copy link

🚀 lgtm once tests pass :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.246% when pulling 51c3370 on SDS-212/fix_atAll_flex_classes into cfc82d4 on master.

@akdetrick akdetrick merged commit 567aee1 into master Mar 15, 2017
@chenrui333 chenrui333 deleted the SDS-212/fix_atAll_flex_classes branch September 16, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eilinora eilinora eilinora approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@akdetrick @eilinora @coveralls