Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache yarn and node modules #131

Merged
merged 1 commit into from
Mar 16, 2017
Merged

cache yarn and node modules #131

merged 1 commit into from
Mar 16, 2017

Conversation

mattkime
Copy link
Contributor

Primary motivation is to avoid 502 errors but it will be interesting to see if there are build perf improvements.

Copy link
Contributor

@mmcgahan mmcgahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this looks good, would you be able to add this to our other repos?

@mattkime
Copy link
Contributor Author

@mmcgahan yes, but lets give this a trial run for a week just in case there are any hidden problems.

@coveralls
Copy link

coveralls commented Mar 16, 2017

Coverage Status

Coverage remained the same at 85.246% when pulling ebf0088 on cache_yarn_node_modules into 567aee1 on master.

@mattkime
Copy link
Contributor Author

Might be too much variation to call it but it looks like the travis builds took 3-4min before this change. This took about 2min to build.

@mattkime mattkime merged commit ede53c5 into master Mar 16, 2017
@chenrui333 chenrui333 deleted the cache_yarn_node_modules branch September 16, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants