adding state to track if user is on keyboard to control hover & focus… #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed styles of dropdown list items
mmcgahan
reviewed
Oct 19, 2018
src/interactive/Dropdown.jsx
Outdated
| }; | ||
|
|
||
| class Dropdown extends React.PureComponent<Props, State> { | ||
| state = { | ||
| isActive: this.props.isActive || false, | ||
| isKeyPressed: true, |
There was a problem hiding this comment.
should this be initialized to true? code comment to explain this choice?
There was a problem hiding this comment.
I initialized it to have the same shape as State, false would be a better choice
src/interactive/Dropdown.jsx
Outdated
| @@ -100,6 +102,9 @@ class Dropdown extends React.PureComponent<Props, State> { | |||
| this.closeContent(e); | |||
| }, 0); | |||
| } | |||
| this.setState({ | |||
| isKeyPressed: true, | |||
| }); | |||
There was a problem hiding this comment.
total nitpick, but you can make this a little tighter on one line
this.setState({ isKeyPressed: true });
src/interactive/Dropdown.jsx
Outdated
| @@ -122,6 +127,12 @@ class Dropdown extends React.PureComponent<Props, State> { | |||
| } | |||
| }; | |||
|
|
|||
| onMouseLeave = (e: SyntheticMouseEvent<*>) => { | |||
There was a problem hiding this comment.
do you need to define the e arg here? i.e. does eslint or flow warn if you skip it? If not, I'd leave it out
There was a problem hiding this comment.
It's not required since it isn't used
mmcgahan
approved these changes
Oct 19, 2018
chenrui333
deleted the
MG-3117_dropdown_hover_styling_removed_on_mouse_leave
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes https://meetup.atlassian.net/browse/MG-3117
Description
Tracks keyboard usage in state to apply styles based on index when navigating through the list only when a keyboard is used.