This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Don't log 4XX errors as error-level in our logs for right now #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-will-h
commented
Sep 22, 2017
| }); | ||
|
|
||
| // Only want to warn about 400s for now (maybe forever?) | ||
| if (statusCode < 500) { |
There was a problem hiding this comment.
Truthfully, I'm not sure if new relic picks these up, but I think better to err on the side of caution.
There was a problem hiding this comment.
yeah i'm guessing it watches stderr
h-will-h
commented
Sep 22, 2017
| const log = ((statusCode >= 400 && logger.error) || | ||
| (statusCode >= 300 && logger.warn) || | ||
| const log = ((statusCode >= 500 && logger.error) || | ||
| (statusCode >= 400 && logger.warn) || |
There was a problem hiding this comment.
I'm betting on this definitely making a difference.
mmcgahan
suggested changes
Sep 22, 2017
| if (response.statusCode >= 400) { | ||
| // Don't throw an error for 400s for now (maybe forever?) | ||
| return formatApiError({ message: response.statusMessage }, value); | ||
| } |
There was a problem hiding this comment.
this has the same effect of the previous implementation - formatApiError expects an Error instance and will take the message prop from it without throwing.
There was a problem hiding this comment.
Yeah, I did this first and it I don't think it's helpful. Removed.
| if (statusCode < 500) { | ||
| console.warn(errorMessageString); | ||
| } else { | ||
| console.error(errorMessageString); | ||
| } |
There was a problem hiding this comment.
trivially DRYer alternative
const logError = statusCode < 500 ? console.warn : console.error;
logError(errorMessageString);
added 2 commits
September 21, 2017 20:23
|
OK, comments addressed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.