Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown option: vimside-log-file-path #9

Open
fayimora opened this issue Jan 11, 2013 · 4 comments
Open

Unknown option: vimside-log-file-path #9

fayimora opened this issue Jan 11, 2013 · 4 comments

Comments

@fayimora
Copy link

Trying to startup ensime gives me the error below
Screen Shot 2013-01-11 at 00 00 29
I have looked at both the options and config file but to no avail.

I added this call owner.Set("vimside-log-file-path", $HOME . "/.vimside_log") to options_user.vim and created ~/.vimside_log but all efforts were futile as nothing changed.

What's up with that option? I can see it it used in https://github.com/megaannum/vimside/blob/master/autoload/vimside/log.vim.

Is there any reason why s:log_enabled isin't used as a guard in vimside#log#error(msg) as it's used in vimside#log#log(msg)(referring to the same log.vim above)

@megaannum
Copy link
Owner

On 01/10/2013 04:13 PM, Fayimora Femi-Balogun wrote:

Trying to startup ensime gives me the error below
Screen Shot 2013-01-11 at 00 00 29
https://f.cloud.github.com/assets/648684/58777/f349a598-5b81-11e2-83f2-42bb71f3c623.png
I have looked at both the options and config file but to no avail.

In the file autoload/vimside/options/manager.vim if there
is no vimside-log-file-path Option value, it creates
a value for it. The bug you found might have
prevented this from happening.
If you look at the code it will either
create the log in
the current working directory
ensime config directory
or
$HOME directory.

I added this |call owner.Set("vimside-log-file-path", $HOME .
"/.vimside_log")| to |options_user.vim| and created |~/.vimside_log| but
all efforts were futile as nothing changed.

What's up with that option? I can see it it used in
|https://github.com/megaannum/vimside/blob/master/autoload/vimside/log.vim|.

Is there any reason why |s:log_enabled| isin't used as a guard in
|vimside#log#error(msg)| as it's used in
|vimside#log#log(msg)|(referring to the same |log.vim| above)

This code is pre-alpha. I want any/all errors to be logged.
Thus, logging with vimside#log#error(msg) is always
enabled.
As the code progresses through beta, an error logging
guard might be created.
The downside is that folks will get errors and will not
be able to report them.

Also, on the roadmap is to review all of the error handling
code (some of it logs and error message and then keeps on
going).


Reply to this email directly or view it on GitHub
#9.

Quis custodiet ipsos custodes

@fayimora
Copy link
Author

Thanks for the explanation. I'll be expecting the fix this weekend as you mentioned in #4

@fayimora
Copy link
Author

fayimora commented Mar 4, 2013

So I decided to give vimside another shot. Every command I run emits errors, mainly complaining about the log_enabled variable. Please see an example screenshot below. Command was vh

Screen Shot 2013-03-04 at 20 50 15

@megaannum
Copy link
Owner

Did you first start Vimside and Ensime (see plugin/vimside.vim) by
calling gui: or non-gui vs ?
During the call to start Vimside, the options are given
their default values, Ensime backend server is started and
there are calls to the Logger.
I do not understand why one would get errors in the
logging function while calling Hover and not first get errors
when the Start Ensime command is first invoked?

If you did indeed start Vimside/Ensime first, what was in the
log file?

Thanks

megaannum

On 03/04/2013 12:56 PM, Fayimora Femi-Balogun wrote:

So I decided to give vimside another shot. Every command I run emits
errors, mainly complaining about the |log_enabled| variable. Please see
an example screenshot below. Command was vh

Screen Shot 2013-03-04 at 20 50 15
https://f.cloud.github.com/assets/648684/218587/df306190-850d-11e2-9b3c-ec4f026d57f3.png


Reply to this email directly or view it on GitHub
#9 (comment).

Quis custodiet ipsos custodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants