Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid grouping example confusing #5339

Closed
tacoWanneeJama opened this issue Mar 1, 2024 · 5 comments
Closed

DataGrid grouping example confusing #5339

tacoWanneeJama opened this issue Mar 1, 2024 · 5 comments
Assignees
Labels
Area: Documentation Something is missing in the documentation. Type: Feature ⚙ Request or idea for a new feature.
Projects
Milestone

Comments

@tacoWanneeJama
Copy link

I was playing with the first example of page: https://blazorise.com/docs/extensions/datagrid/features/grouping
When you sort on the gender only one gender-group is displayed. When you remove the sorting on the gender you can see all gender-groups.
image

At first glace this looked lik a bug. But looking further I see, that the visible rows are a subset of the rows of the datasource. So you don't see the same rows when you change the sorting. This is very confusing to me.
I would suggest to adjust the example so that every time the same rows are shown.

@tacoWanneeJama tacoWanneeJama added the Type: Feature ⚙ Request or idea for a new feature. label Mar 1, 2024
@David-Moreira
Copy link
Contributor

When you sort on the gender only one gender-group is displayed.

I was just testing this. Yea I was confused at first also. The thing is, only 10 records are displayed at a time from a total of like 500.

If you order by Gender, well you get only the first gender records, so other buckets do not show as there's no records for the other buckets in this page. This seems correct, but maybe a little confusing indeed.

We can indeed change the example to just handle like a few records which should be more clear. But I'm thinking if we should do anything else here to be more clear when there's alot of records?

@stsrki any thoughts?

@stsrki
Copy link
Collaborator

stsrki commented Mar 1, 2024

If you use ReadData mode, then this is how it behaves, as we don't see all the records. With ReadData, the developer is responsible for the proper fetching and grouping of data.

On the other hand, if this is in memory, then it is definitely wrong.

@David-Moreira
Copy link
Contributor

David-Moreira commented Mar 1, 2024

If you use ReadData mode, then this is how it behaves, as we don't see all the records. With ReadData, the developer is responsible for the proper fetching and grouping of data.

On the other hand, if this is in memory, then it is definitely wrong.

It's our docs:
https://blazorise.com/docs/extensions/datagrid/features/grouping

Why do you say it's definitely wrong? Are you jumping the gun? Did you understand the "issue" 100%?

If you order by gender which is the column the data is being grouped on.
Since we all alot of data, the the first 10 records will certainly only belong to a single bucket, so only a single bucket (group) shows.

If you say it's definetly wrong, what do you think should happen?

  • All buckets show? But other buckets are empty?
  • Not able to order at all by that column, since it's the column the data is grouped on?
    • Nah I don't think this even makes sense.

@stsrki
Copy link
Collaborator

stsrki commented Mar 1, 2024

I see now. Didn't understand that problem is on our demo.

It seems like a bug, indeed. Would it help if we enabled pagination? That way users would see that there is more data available.

@David-Moreira
Copy link
Contributor

I see now. Didn't understand that problem is on our demo.

It seems like a bug, indeed. Would it help if we enabled pagination? That way users would see that there is more data available.

Right It seems like a bug, but I am thinking that's it. It just seems like it.
Either we reduce the amount of data so it's clearer. Or allow pagination like you just suggested, that might be indeed a bit clearer.

@David-Moreira David-Moreira added this to 🔙 Backlog in Support via automation Mar 1, 2024
@David-Moreira David-Moreira self-assigned this Mar 1, 2024
@David-Moreira David-Moreira added this to the 1.4 support milestone Mar 1, 2024
@David-Moreira David-Moreira added the Area: Documentation Something is missing in the documentation. label Mar 1, 2024
@David-Moreira David-Moreira moved this from 🔙 Backlog to 💪 In progress in Support Mar 9, 2024
@David-Moreira David-Moreira moved this from 💪 In progress to ⏳ In Review in Support Mar 9, 2024
@stsrki stsrki closed this as completed Mar 9, 2024
Support automation moved this from ⏳ In Review to ✔ Done Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Something is missing in the documentation. Type: Feature ⚙ Request or idea for a new feature.
Projects
Support
  
✔ Done
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants