Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component - NFT Cards #47

Closed
Tracked by #15
Rajdip019 opened this issue Mar 2, 2022 · 6 comments · Fixed by #49
Closed
Tracked by #15

Component - NFT Cards #47

Rajdip019 opened this issue Mar 2, 2022 · 6 comments · Fixed by #49
Assignees
Labels
1-Day Submission in 1 Day GSSoC22 Girl Script Summer of Code 2022 Level1

Comments

@Rajdip019
Copy link

Rajdip019 commented Mar 2, 2022

Describe the bug
The card is not a component although it will be used the multiple times in the website.

Expected behaviour
The card should be component.

I would love to work on this.

@raysummee
Copy link
Collaborator

Thank you for pointing this out. I'll add this into the main task.

@raysummee raysummee changed the title Make card as a component Component - NFT Cards Mar 2, 2022
@raysummee
Copy link
Collaborator

Components - NFT Cards

tracking in #15

  • The folder should be like follows:
    js: components/components-name/components-name.js
    css: components/components-name/components-name.module.css

Figma Link: click here

@raysummee raysummee added GSSoC22 Girl Script Summer of Code 2022 Level1 labels Mar 2, 2022
@raysummee
Copy link
Collaborator

@Rajdip019 you can assign it to you. You may start working on it now.

@Rajdip019
Copy link
Author

Thanks will start working on this today.

@raysummee
Copy link
Collaborator

@Rajdip019 Please use params to get the title and description of the NFT in NFT Cards. The values should be pass from parent component.

@raysummee raysummee mentioned this issue Mar 3, 2022
@Rajdip019
Copy link
Author

I have used props to pass all info from parent to the component. @raysummee

@raysummee raysummee linked a pull request Mar 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Day Submission in 1 Day GSSoC22 Girl Script Summer of Code 2022 Level1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants