Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace class with Struct for data entity #4

Open
gaufung opened this issue Sep 7, 2023 · 4 comments
Open

Replace class with Struct for data entity #4

gaufung opened this issue Sep 7, 2023 · 4 comments

Comments

@gaufung
Copy link
Contributor

gaufung commented Sep 7, 2023

There are various class that represents the data entity. we can switch to struct to reduce heap memory if possible.
@observeralone
Copy link
Collaborator

Thank you for your advice. The choice between using a class or a struct depends on the requirements and design considerations. So, which parts of this project do you think could be changed to use structs, and how would you suggest making those modifications?

@gaufung
Copy link
Contributor Author

gaufung commented Sep 12, 2023

C# has been evolving since .NET 5. Struct has many benefits in peformance.

@gaufung
Copy link
Contributor Author

gaufung commented Sep 12, 2023

will improve that in the following PRs.

@observeralone
Copy link
Collaborator

will improve that in the following PRs.

which class of this project do you think could be changed to use structs?
If you are interested, you can help improve it and then submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@observeralone @gaufung