Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Iris Framework #24

Closed
bigangryrobot opened this issue Jun 16, 2021 · 3 comments
Closed

Remove the Iris Framework #24

bigangryrobot opened this issue Jun 16, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bigangryrobot
Copy link
Contributor

He folks I was reviewing this for possible use in another project and realized that the iris framework probably should be abandoned. As such I've made a quick pr (there is a few corners cut in the wait groups and signal handling) to bring the codebase under the go-chi http framework.

Please let me know if there is anything missing for this request
#23

@benja-wu benja-wu self-assigned this Jun 16, 2021
@benja-wu
Copy link
Contributor

@bigangryrobot First of all, thanks for your contribution. Your concern about no using iris framework seems reasonable for us. We will review your PR carefully.

BTW: Maybe we can start by opening and discussing in issue first, and then submit a PR next time. That would be better. :-)

@benja-wu benja-wu added the enhancement New feature or request label Jun 16, 2021
@localvar localvar changed the title Remove the Iris Framewor Remove the Iris Framework Jun 16, 2021
@benja-wu benja-wu pinned this issue Jun 16, 2021
@haoel
Copy link
Contributor

haoel commented Jun 16, 2021

@bigangryrobot Thanks so much raise this issue and PR, it's just the right time while we are looking for some possible alternatives recently. Thanks for this PR to lead us to make it real!

--Hao

@benja-wu
Copy link
Contributor

Merged by PR #23

@benja-wu benja-wu unpinned this issue Jun 17, 2021
@benja-wu benja-wu added this to the v1.0.1 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants