chart: add chart files for helm-install #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megaeasex
approved these changes
Sep 13, 2021
|
This helm chart is dedicated to the K8s ingress controller of the Easegress. As Easegress can be used in different scenarios, I think you'd better explicitly explain the intention in the chart (including use more clear names or add some comments, etc...) for avoiding confusing people. |
|
Please rename the |
megaeasex
approved these changes
Sep 14, 2021
megaeasex
approved these changes
Sep 14, 2021
localvar
reviewed
Sep 26, 2021
| @@ -0,0 +1,4 @@ | |||
| apiVersion: v2 | |||
| name: easegress-controller | |||
There was a problem hiding this comment.
Suggested change
| name: easegress-controller | |
| name: easegress-ingress-controller |
Comment on lines
1
to
5
| # easegress ingress-controller chart | ||
|
|
||
| Use for easegress ingress controller installation by helm on kubernetes. | ||
|
|
||
| ## usage |
There was a problem hiding this comment.
Suggested change
| # easegress ingress-controller chart | |
| Use for easegress ingress controller installation by helm on kubernetes. | |
| ## usage | |
| # Easegress ingress controller chart | |
| Helm charts for install Easegress ingress controller on Kubernetes. | |
| ## Usage |
localvar
approved these changes
Sep 27, 2021
megaeasex
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#237