set timeout for kafka client conn #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 85 85
Lines 5842 5842
=======================================
Hits 5788 5788
Misses 40 40
Partials 14 14 ☔ View full report in Codecov by Sentry. |
LokiWager
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for the Kafka client, the timeout is only applicable during the dialing process. Once the connection is established and conn.ReadPartitions is called, it may experience significant delays. This situation can occur if the Kafka server is unresponsive or slow to write responses, potentially taking several minutes. To address this issue, this pr introduces a timeout setting for the connection.
This may cause the problem in issue #442 .