Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaped quote converted to backtick instead of string end's one #66

Open
erkage opened this issue Mar 26, 2022 · 2 comments
Open

Escaped quote converted to backtick instead of string end's one #66

erkage opened this issue Mar 26, 2022 · 2 comments
Assignees
@meganrogge
Labels
bug Something isn't working

Comments

@erkage
Copy link

erkage commented Mar 26, 2022

Screen Recording 2022-03-26 at 10 40 18
@meganrogge
Copy link
Owner

I think setting template-string-converter.convertOutermostQuotes to true will fix that

@erkage erkage changed the title Escaped tick/quote converted to backtick instead of string end's one Escaped quote converted to backtick instead of string end's one Mar 27, 2022
@erkage
Copy link
Author

erkage commented Mar 27, 2022

Thanks for the reply!
Yes, it's fixed it but this is intentional or accidental? 🙂
I mean the escaped ones may be should not count as "real" quotes!?

@meganrogge meganrogge self-assigned this Mar 28, 2022
@meganrogge meganrogge added the bug Something isn't working label Mar 28, 2022
Lete114 added a commit to Lete114/template-string-magic that referenced this issue Jul 3, 2024
@Lete114
fix: Escaped quote converted to backtick instead of string end's one
0301abe 
from: meganrogge/template-string-converter#66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erkage @meganrogge