Streaming download fails with "Invalid argument" for public node

[vozhyk-]

Download to a file works correctly, but a streaming download fails with "Invalid argument".

% ./mega-streaming-test   
[00:58:13][info] Request (GET_PUBLIC_NODE) starting
[00:58:16][info] Request (GET_PUBLIC_NODE) finished
node size: 1790981
---- Normal download:
[00:58:17][info] Transfer (DOWNLOAD) starting. File: test
onTransferUpdate: buf 0 size 0
onTransferUpdate: buf 0 size 2416
onTransferUpdate: buf 0 size 25368
onTransferUpdate: buf 0 size 288712
onTransferUpdate: buf 0 size 324352
onTransferUpdate: buf 0 size 408312
onTransferUpdate: buf 0 size 344280
onTransferUpdate: buf 0 size 257936
[00:58:17][info] Transfer (DOWNLOAD) finished. File: test
onTransferFinish: No error

---- Streaming download:
[00:58:18][warn] Transfer (DOWNLOAD) finished with error: Invalid argument File: (NULL)
onTransferFinish: Invalid argument

https://gist.github.com/vozhyk-/800b1591dea1a6f60804#file-main-cpp

[vozhyk-]

It seems the error is returned from src/megaapi_impl.cpp:6452

---- Streaming download:

Breakpoint 13, mega::MegaApiImpl::sendPendingTransfers (this=0x61c060)
    at src/megaapi_impl.cpp:6452
6452                    if(!node && !publicNode) { e = API_EARGS; break; }
(gdb) cont
Continuing.

Breakpoint 1, mega::MegaError::getErrorString (errorCode=-2)
    at src/megaapi.cpp:650
650                 return "Invalid argument";
(gdb) cont
Continuing.
[01:26:32][warn] Transfer (DOWNLOAD) finished with error: Invalid argument File: (NULL)

[vozhyk-]

Now I see, this just isn't implemented.

//TODO: Implement streaming of public nodes

But anyway, the error was returned from src/megaapi_impl.cpp:6555 only after I've set publicNode to the value it had during non-streaming download using gdb.

[javiserrano]

Hi, thank you for your report!
I have just implemented streaming of public nodes in the last commit of the master branch.
Please, let me know if there is still any problem.

[vozhyk-]

Great, thanks! I will see how it works.

[javiserrano]

Sorry for commenting in your closed issue.
I've seen your megahttp project and it looks really good :-)
Please, don't hesitate to contact us if you find any bug in our SDK, if you have any doubt about its usage or you need some assistance.

[vozhyk-]

I'm glad you like it:) . Thank you!