Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: WFS and Style #160

Merged
merged 9 commits into from
Dec 23, 2020
Merged

Conversation

JakobMiksch
Copy link
Collaborator

@JakobMiksch JakobMiksch commented Dec 22, 2020

  • add docs for WFS
  • add docs for Style including Labels
  • make mandatory properties bold and remove column "mandatory". This makes the docs less verbose.
  • Update the version number

TODO:

  • add remark that bold properties are mandatory

Copy link
Collaborator

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I added some points, which should be addressed before merging.

docs/map-layer-configuration.md Outdated Show resolved Hide resolved
docs/map-layer-configuration.md Outdated Show resolved Hide resolved
docs/map-layer-configuration.md Outdated Show resolved Hide resolved
docs/map-layer-configuration.md Outdated Show resolved Hide resolved
docs/map-layer-configuration.md Outdated Show resolved Hide resolved
docs/map-layer-configuration.md Outdated Show resolved Hide resolved
docs/map-layer-configuration.md Show resolved Hide resolved
docs/map-layer-configuration.md Outdated Show resolved Hide resolved
docs/map-layer-configuration.md Show resolved Hide resolved
docs/map-layer-configuration.md Show resolved Hide resolved
@justb4
Copy link
Collaborator

justb4 commented Dec 22, 2020

Good to have mandatory attrs in bold! Is it an idea to also add a default column for non-mandatory attrs (where applicable)? This is often expressed in the 'meaning' text.

JakobMiksch and others added 4 commits December 22, 2020 17:36
Co-authored-by: Christian Mayer <chris@meggsimum.de>
Co-authored-by: Christian Mayer <chris@meggsimum.de>
@JakobMiksch
Copy link
Collaborator Author

JakobMiksch commented Dec 22, 2020

@justb4 I like the idea of having a column for default values. I do not see this change in this PR, but I will open an issue: #161

@chrismayer
Copy link
Collaborator

This is good to go, thanks @JakobMiksch! I'll merge now.

@chrismayer chrismayer merged commit 869ee59 into wegue-oss:master Dec 23, 2020
@JakobMiksch JakobMiksch deleted the docs_wfs_layerstyle branch March 26, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants