-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor mwe module #38
Conversation
ccd6710
to
d90cc96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @leobeeson! <3
See my comments below.
We also can drop __init__.py
in the test directory. Pytest modules don't need it and Pytest docs recommend not including them. See here.
…text is being tokenized.
d90cc96
to
ed58735
Compare
…anumeric, in latinscript, and has more than two characters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments below.
@leobeeson when running pre-commit, I get a bunch of PEP and static type errors thrown by pre-commit (flake8 and mypy). I wonder if you use the instructions here. I always use pre-commit and it's pretty helpful. First, isort and black edit the code to a nice format, and then mypy runs and checks static types and a bunch of other things, preventing many future run time errors, practically making the code much more stable. If you install pre-commit following the instructions above, it runs each time that you commit code, blocking the commit until the issues are addressed. For the already committed code, you can simply run Here is a screenshot of the pre-commit (mypy, flake8) errors in am.py ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Thanks!
Refactor MWE Module
Resolves #35 .
Situation
Solution
NB