add regularizer #73
Open
add regularizer #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeiqinSun
reviewed
Nov 25, 2022
| @@ -34,6 +35,7 @@ def __init__(self, model: nn.Module, config): | |||
| self._run_simplifiers() | |||
| self._convert2quantmodule() | |||
| self._build_quantizer() | |||
| self._build_regularizer() | |||
There was a problem hiding this comment.
不建议成为quant_model的一部分, 而是由用户直接在main函数中调用
PeiqinSun
reviewed
Nov 25, 2022
| REGULARIZER: | ||
| ENABLE: True | ||
| TYPE: dampen | ||
| LAMBDA: 0.01 |
There was a problem hiding this comment.
不建议lambda作为quant_config一部分, 而是应该成为main.py parser的一部分
lz02k
force-pushed
the
lz02k/add_regularizer
branch
from
8bd7bbc
to
8397203
Compare
PeiqinSun
reviewed
Dec 9, 2022
| self.config = config | ||
|
|
||
| def _get_loss(self, x, quantizer): | ||
|
|
PeiqinSun
reviewed
Dec 9, 2022
| scale = scale.detach() | ||
| zero_point = zero_point.detach() | ||
|
|
||
| min_val = (qmin - zero_point) * scale |
There was a problem hiding this comment.
should use quant_drange api
https://github.com/megvii-research/Sparsebit/blob/main/sparsebit/quantization/quantizers/quant_tensor.py#L212
lz02k
force-pushed
the
lz02k/add_regularizer
branch
from
7189c8a
to
4c5ae67
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @PeiqinSun @Jiang-Stan