Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dirs dep #38

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Remove dirs dep #38

merged 1 commit into from
Apr 22, 2023

Conversation

utkarshgupta137
Copy link
Contributor

No description provided.

@SabrinaJewson
Copy link
Collaborator

Given that I don’t believe this part of the codebase is useful on Windows anyway, might it be better to just use std::env::home_dir? It’s what home shells out to on Unix platforms.

@utkarshgupta137
Copy link
Contributor Author

Given that I don’t believe this part of the codebase is useful on Windows anyway, might it be better to just use std::env::home_dir? It’s what home shells out to on Unix platforms.

Sure, let me update

@utkarshgupta137 utkarshgupta137 changed the title Move to the smaller, cargo-team maintained home crate Remove dirs dep Apr 22, 2023
@SabrinaJewson SabrinaJewson merged commit e2e4f73 into meh:master Apr 22, 2023
1 check passed
@SabrinaJewson
Copy link
Collaborator

Thanks!

@utkarshgupta137
Copy link
Contributor Author

Can you create a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@utkarshgupta137 @SabrinaJewson