Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readv/writev instead of recvmsg/sendmsg #44

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

0e4ef622
Copy link
Contributor

@0e4ef622 0e4ef622 commented Sep 25, 2021

Attempting to use vectored read/write on linux was resulting in ENOTSOCK.

Fixes #43.

@spacemeowx2
Copy link

It works for me.

@canselcik
Copy link

This fixes it.

@HsuJv
Copy link

HsuJv commented Dec 5, 2021

Awesome! It works for me

@rappet
Copy link

rappet commented Jan 8, 2022

It does also work for me on Linux version 5.11.0-44-generic (buildd@lcy02-amd64-027) (gcc (Ubuntu 10.3.0-1ubuntu1) 10.3.0, GNU ld (GNU Binutils for Ubuntu) 2.36.1) #48-Ubuntu SMP Fri Dec 10 09:46:22 UTC 2021. Thanks!

@zu1k
Copy link

zu1k commented Feb 20, 2022

It works for me.

Linux zu1k 5.16.7-1-MANJARO #1 SMP PREEMPT Sun Feb 6 12:22:29 UTC 2022 x86_64 GNU/Linux

@llc1123
Copy link

llc1123 commented Mar 20, 2022

LGTM

@Voronar
Copy link

Voronar commented Jun 8, 2022

It works for me on Android 10-11 (aarch64).

@meh meh merged commit d97c19a into meh:master Jun 8, 2022
@imlk0
Copy link
Contributor

imlk0 commented Jul 27, 2022

@meh This is a really essential fix, can you release a new version on crates.io?

@meh
Copy link
Owner

meh commented Jul 27, 2022

Yup, can you ping me again tomorrow if I don't please? In bed with covid.

@0e4ef622 0e4ef622 deleted the fix_not_sock branch July 28, 2022 12:58
@yinheli
Copy link

yinheli commented Aug 30, 2022

ping @meh

Could you please check this ? for release new version crates.io ?

@imlk0
Copy link
Contributor

imlk0 commented Aug 30, 2022

ping @meh

zonyitoo pushed a commit to zonyitoo/rust-tun that referenced this pull request Feb 18, 2024
* migrate to ipnet

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket operation on non-socket