'boundKeyPressCombos' (a nil value)

[ericcobblepot]

Priority

Low

Area

• Data
• Source
• Docker
• Other

What happened?

I don't know how to reproduce, it only appears a couple of times, just by type on the keyboard

ERROR: Lua exception: /corelib/keyboard.lua:103: attempt to index field 'boundKeyPressCombos' (a nil value)
stack traceback:
    [C]: in function '__index'
    /corelib/keyboard.lua:103: in function </corelib/keyboard.lua:99>
ERROR: protected lua call failed: LUA ERROR:
/corelib/keyboard.lua:103: attempt to index field 'boundKeyPressCombos' (a nil value)
stack traceback:
    [C]: in function '__index'
    /corelib/keyboard.lua:103: in function </corelib/keyboard.lua:99>

What OS are you seeing the problem on?

Windows

Code of Conduct

• I agree to follow this project's Code of Conduct

[Nottinghster]

Try this:

local function onWidgetKeyPress(widget, keyCode, keyboardModifiers, autoRepeatTicks)
    if keyCode == KeyUnknown then
        return false
    end

    local boundKeyPressCombos = widget.boundKeyPressCombos or {}
    local callback = widget.boundKeyPressCombos[determineKeyComboDesc(keyCode, keyboardModifiers)]
    return signalcall(callback, widget, keyCode, autoRepeatTicks)
end

[luanluciano93]

@ericcobblepot Did you test with @Nottinghster suggestion?

[ericcobblepot]

local boundKeyPressCombos = widget.boundKeyPressCombos or {}

or {}

this only prevents the error in console
It is a patch solution

[kojimhojo]

@ericcobblepot

I found a way to reproduce it

1: open console
> g_game.requestChannels()

2: press the key SCAPE

3: bug:

ERROR: Lua exception: /corelib/keyboard.lua:103: attempt to index field 'boundKeyPressCombos' (a nil value)
stack traceback:
    [C]: in function '__index'
    /corelib/keyboard.lua:103: in function </corelib/keyboard.lua:99>
ERROR: protected lua call failed: LUA ERROR:
/corelib/keyboard.lua:103: attempt to index field 'boundKeyPressCombos' (a nil value)
stack traceback:
    [C]: in function '__index'
    /corelib/keyboard.lua:103: in function </corelib/keyboard.lua:99>

[leoddias]

@Nottinghster why do you closed it? The solution that you provided didn't worked.
This bug still happen on "main" branch.

Also I have issues with hotkeys in general, sometimes all hotkeys stop to work, I should logoff and login in order to have them working again... idk how to reproduce it yet.

[leoddias]

I found a way to reproduce the hotkeys bug:
Keep Pressing CTRL+G while clicking in Cancel Button, do it few times and any ComboKeys (F1~F12, etc) will work.

It happens sometimes while playing idk why.

[kokekanon]

2024-08-25.15-28-34.mp4

apparently the error is related to this

https://github.com/mehah/otclient/blob/main/modules/corelib/ui/uiwindow.lua#L50-L62
on
f247211