Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: move client SPRITE_SIZE out of the framework #448

Merged
merged 1 commit into from Mar 2, 2023

Conversation

BenDol
Copy link
Collaborator

@BenDol BenDol commented Mar 2, 2023

Description

Move client SPRITE_SIZE out of the framework (I use the framework for my server implementation, so I catch these haha)

@mehah
Copy link
Owner

mehah commented Mar 2, 2023

I gladly accept, but I would like to understand why, since g_drawPool is a singleton, is it just to take the responsibility off config.h?

@BenDol
Copy link
Collaborator Author

BenDol commented Mar 2, 2023

Yes, since I use framework for my server implementation any client code i.e. config.h breaks my build. Any framework specific changes should be agnostic to the client sources I think.

@mehah mehah merged commit 1b4a1d1 into mehah:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants