improve: Attached Effect (new props) #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
added a commit
that referenced
this pull request
Nov 17, 2023
Resolves #449 With the wrong size, instead of getting all possible pages, it was stopping at the eighth page, which is the maximum number of items in uint8_t, so when there were more items it allowed to clone in a specific scenario, I will avoid giving examples so that they do not abuse the bug on the server of those who are not using the fix yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New properties for the attached effect system
loop(number): quantity of loop that the effect will remain active.
duration(number): duration of effect.
transform(bool): Instead of attaching, the character will change the outfit.
hideOwner(bool): Hide the owner where the effect was attached.
sample:
2023-03-06.19-43-16-1.mp4