Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spells cooldown if UINT16 is expected #542

Merged
merged 2 commits into from
Jun 2, 2023
Merged

fix: spells cooldown if UINT16 is expected #542

merged 2 commits into from
Jun 2, 2023

Conversation

yrpen
Copy link
Contributor

@yrpen yrpen commented Jun 1, 2023

Description

Fix spells cooldown if UINT16 is expected.
Fix by fusion32 from otland.

Behaviour

Actual

  • There is no spell cooldown in client 10.98, after using spell.
  • If last hit is done by spell, creature still appear as alive in battle list and game screen
  • There is nil value error in OTC

Same issue:
https://otland.net/threads/solved-otclient-lua-exception-attempt-to-index-local-spell-a-nil-value.284728/#post-2722382
https://otland.net/threads/help-request-spell-damage-causes-visual-bug-on-monster-death.284723/#post-2722327

Expected

  • Show spell cooldown in client 10.98, after using spell.
  • Killed monster die
  • There is no error in OTC

Fixes

It is partialy resolve
# #527

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • I used exura to test healing spells.
  • I used exori vis to test killing monsters with spells

Test Configuration:

  • Server Version: TFS 1.4.2
  • Client: commit 47a3e59
  • Operating System: Linux (Ubuntu 20.04)
  • I use docker to run client

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mehah
Copy link
Owner

mehah commented Jun 1, 2023

do you intend to correct something else in this pr?

@yrpen
Copy link
Contributor Author

yrpen commented Jun 2, 2023

do you intend to correct something else in this pr?

No. I'll create separate Pull Request to add new spells in spellbook and cooldown groups.
But only after I fix my .otui file.

@mehah mehah changed the title Fix spells cooldown if UINT16 is expected fix spells cooldown if UINT16 is expected Jun 2, 2023
@mehah mehah changed the title fix spells cooldown if UINT16 is expected fix: spells cooldown if UINT16 is expected Jun 2, 2023
@mehah mehah merged commit 5b40948 into mehah:main Jun 2, 2023
10 checks passed
dudantas pushed a commit that referenced this pull request Nov 17, 2023
The Fear Condition is a status condition that makes the affected creature lose control of their movements for a short period of time. During this period, the affected creature randomly moves around in various directions, unable to perform any other actions. This condition is usually brought about by certain spells or monster effects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants