Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle on/off console using ENTER and toggle off console using ESC #549

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

yrpen
Copy link
Contributor

@yrpen yrpen commented Jun 11, 2023

Description

Toggle on/off WSAD walking using ENTER.
Toggle on WSAD walking using ESC.

Behaviour

Actual

You can toggle on/off WSAD walking only using mouse pointer.

Expected

You can toggle on/off WSAD walking using mouse pointer.
You can toggle off WSAD walking using ENTER.
You can toggle on WSAD walking using ENTER if there is no text message in text field.
You can toggle on WSAD walking using ESC.

Type of change

Please delete options that are not relevant.

  • Bug fix?
  • New feature?

How Has This Been Tested

  • Edit text on letter to check if ENTER and ESC works as usual
  • Send some messages on chat to test if it's not broken
  • Write spells on console
  • Use spells using hotkeys

Test Configuration:

  • Server Version: TFS 1.4.2
  • Client commit: 5b40948
  • Tested client protocol: 10.98, 12.86
  • Operating System: Linux, Ubuntu 20.04
  • Tested with docker container

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@yrpen
Copy link
Contributor Author

yrpen commented Jun 12, 2023

How can we see failed check details?
It shouldn't fail on build step as it's lua only change.

@mehah mehah changed the title toggle on/off console using ENTER and toggle off console using ESC feat: toggle on/off console using ENTER and toggle off console using ESC Jun 13, 2023
@mehah mehah merged commit ce8a670 into mehah:main Jun 13, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants