improve: add almost all missing spell group cooldown; add missing spells from …

[yrpen]

Description

• add almost all missing spell group cooldown - graphic, names, small cooldown otui rework
• add missing spells from 9.80, 10.55, 11.40.5409, 12.55.10451, 12.80.1430 - graphic, spell list, cooldown
• add draft for spells from 13.10.12852 - graphic, commented parts of code for spell list and cooldown
• adjust some spells changes in secondary cooldown group

Behaviour

Actual

Missing some spells groups and spells in client cooldown panel and spell list.

Expected

Have all of them.

Fixes

# #527

Type of change

• New feature.
• Breaking change. Some spells changed. So this update can fit new clients but not old.

How Has This Been Tested

I used new spells and old spells and check cooldown bar.

Test Configuration:

• Server Version: TFS 1.4.2
• Protocol: 10.98
• Client: latest commit
• Operating System: Linux

I also tested it on 12.x

Tested spells

Spell name	Words	TFS ID	Version	URL
Practise Healing	exura dis	166	9.80	https://tibia.fandom.com/wiki/Practise_Healing
Practise Fire Wave	exevo dis flam hur	167	9.80	https://tibia.fandom.com/wiki/Practise_Fire_Wave
Apprentice's Strike	exori min flam	169	9.80	https://tibia.fandom.com/wiki/Apprentice's_Strike
Mud Attack	exori infir tera	172	10.55	https://tibia.fandom.com/wiki/Mud_Attack
Chill Out	exevo infir frigo hur	173	10.55	https://tibia.fandom.com/wiki/Chill_Out
Magic Patch	exura infir	174	10.55	https://tibia.fandom.com/wiki/Magic_Patch
Bruise Bane	exura infir ico	175	10.55	https://tibia.fandom.com/wiki/Bruise_Bane
Arrow Call	exevo infir con	176	10.55	https://tibia.fandom.com/wiki/Arrow_Call
Buzz	exori infir vis	177	10.55	https://tibia.fandom.com/wiki/Buzz
Scorch	exevo infir flam hur	178	10.55	https://tibia.fandom.com/wiki/Scorch

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

What is still missing?

• Working checkbox filter in spell list for non vocation (yes, there are spell for those players :) )
• One secondary cooldown group removed from game (I can't find gray graphic to put it into client) - https://tibia.fandom.com/wiki/Conjure_Spells
• 13.10.~ spell details and TFS id
• Tests for a lot of them. I tested them on TFS 1.4.2. So spells up to 10.98 are tested.
• Probably spells Find Fiend and Conjure Wand of Darkness should have another TFS spell id but I can't find good source of it
• I'm not sure how this change should be done. Some changes in spells should depend on protocol version? But I need some examples to rework this.

Spells need tests

I need someone to help test those spells.

Spell name	Words	TFS ID	Version	URL
Conjure Diamond Arrow	exevo gran con hur	192 - later removed from game	11.40.5409	https://tibia.fandom.com/wiki/Conjure_Diamond_Arrow
Conjure Spectral Bolt	exevo gran con vis	193 - later removed from game	11.40.5409	https://tibia.fandom.com/wiki/Conjure_Spectral_Bolt
Conjure Wand of Darkness	exevo gran mort	92	11.40.5409	https://tibia.fandom.com/wiki/Conjure_Wand_of_Darkness
Summon Druid Familiar	utevo gran res dru	197	11.40.5409	https://tibia.fandom.com/wiki/Summon_Druid_Familiar
Summon Knight Familiar	utevo gran res eq	194	11.40.5409	https://tibia.fandom.com/wiki/Summon_Knight_Familiar
Summon Paladin Familiar	utevo gran res sac	195	11.40.5409	https://tibia.fandom.com/wiki/Summon_Paladin_Familiar
Summon Sorcerer Familiar	utevo gran res ven	196	11.40.5409	https://tibia.fandom.com/wiki/Summon_Sorcerer_Familiar
Chivalrous Challenge	exeta amp res	237	12.55.10451	https://tibia.fandom.com/wiki/Chivalrous_Challenge
Fair Wound Cleansing	exura med ico	239	12.55.10451	https://tibia.fandom.com/wiki/Fair_Wound_Cleansing?so=search
Expose Weakness	exori moe	243	12.55.10451	https://tibia.fandom.com/wiki/Expose_Weakness?so=search
Sap Strenght	exori kor	244	12.55.10451	https://tibia.fandom.com/wiki/Sap_Strength?so=search
Great Fire Wave	exevo gran flam hur	240	12.55.10451	https://tibia.fandom.com/wiki/Great_Fire_Wave?so=search
Restoration	exura max vita	241	12.55.10451	https://tibia.fandom.com/wiki/Restoration?so=search
Nature's Embrace	exura gran sio	242	12.55.10451	https://tibia.fandom.com/wiki/Nature's_Embrace?so=search
Divine Dazzle	exana amp res	238	12.55.10451	https://tibia.fandom.com/wiki/Divine_Dazzle
Find Fiend	exiva moe res	20	12.80.11430	https://tibia.fandom.com/wiki/Find_Fiend

Spells needs more data to fully add

I added those graphics and commented some basic informations. So it's done in 90%.

Spell name	Words	TFS ID	Version	URL
Avatar of Light	uteta res sac	- no data	13.10.12852	https://tibia.fandom.com/wiki/Avatar_of_Light
Avatar of Nature	uteta res dru	- no data	13.10.12852	https://tibia.fandom.com/wiki/Avatar_of_Nature
Avatar of Steel	uteta res eq	- no data	13.10.12852	https://tibia.fandom.com/wiki/Avatar_of_Steel
Avatar of Storm	uteta res ven	- no data	13.10.12852	https://tibia.fandom.com/wiki/Avatar_of_Storm
Divine Empowerment	utevo grav san	- no data	13.10.12852	https://tibia.fandom.com/wiki/Divine_Empowerment
Divine Grenade	exevo tempo mas san	- no data	13.10.12852	https://tibia.fandom.com/wiki/Divine_Grenade
Executioner's Throw	exori amp kor	- no data	13.10.12852	https://tibia.fandom.com/wiki/Executioner's_Throw
Gift of Life	? ? ?	- no data	13.10.12852	https://tibia.fandom.com/wiki/Gift_of_Life
Great Death Beam	exevo max mort	- no data	13.10.12852	https://tibia.fandom.com/wiki/Great_Death_Beam
Ice Burst	exevo ulus frigo	- no data	13.10.12852	https://tibia.fandom.com/wiki/Ice_Burst
Terra Burst	exevo ulus tera	- no data	13.10.12852	https://tibia.fandom.com/wiki/Terra_Burst

Spell groups added, but not fully tested

Name	Type
Crippling Spells	Secondary Group
Focus Spells	Secondary Group
Ultimate Strike Spells	Secondary Group
Great Beams Spells	Secondary Group
Burst of Nature Spells	Secondary Group

[github-actions]

This PR is stale because it has been open 45 days with no activity.

[mehah]

@yrpen
any news?

[conde2]

@yrpen is it ready to merge?

[github-actions]

This PR is stale because it has been open 45 days with no activity.