Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: market issues #576

Merged
merged 4 commits into from
Jul 25, 2023
Merged

fix: market issues #576

merged 4 commits into from
Jul 25, 2023

Conversation

alfuveam
Copy link
Contributor

Description

Fix incorrect behavior on open market:
1: ERROR: ProtocolGame parse message exception (39 bytes unread, last opcode is 0, prev opcode is 246): unhandled opcode 0
2: Need open two times to get a balance.

Test Configuration:

  • Server Version: tfs with protocol 12.86
  • Client:fd4833c
  • Operating System: ManjaroLinux_22.1.0

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mehah mehah changed the title Market issues fix: market issues Jul 25, 2023
@mehah mehah merged commit 31d0e2b into mehah:main Jul 25, 2023
10 checks passed
dudantas added a commit that referenced this pull request Nov 17, 2023
This would convert, for example, the RETURNVALUE_NOERROR to "Sorry, not possible", always. Generating a wrong behaviour, since what will be printed will not be the real value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants