errors: clarify names of integer types #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
approved these changes
May 8, 2022
|
Thank you for this PR and especially thank you for taking the time to explain why you did this in the commit message. Highly appreciated! |
|
The CI fail is unrelated, feel free to simply rebase this to latest master and it should be green then 😆 |
I got this error message: ``` invalid type: integer 64 bit `5`, expected an array ``` It took me a while to figure out that it wasn't talking about bit number 5 of the number 64, but the 64-bit number `5`. I think it will be clearer like this: ``` invalid type: 64-bit integer `5`, expected an array ``` So that's what this patch implements.
That's now done. |
matthiasbeyer
approved these changes
May 9, 2022
YounessBird
pushed a commit
to YounessBird/config-rs
that referenced
this pull request
Jun 1, 2022
errors: clarify names of integer types fix yaml to parse int keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this error message:
It took me a while to figure out that it wasn't talking about bit
number 5 of the number 64, but the 64-bit number
5. I think it willbe clearer like this:
So that's what this patch implements.