Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gate async-traits behind a feature #402

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Gate async-traits behind a feature #402

merged 1 commit into from
Dec 6, 2022

Conversation

nstinus
Copy link
Contributor

@nstinus nstinus commented Dec 6, 2022

Fixes #397

matthiasbeyer
matthiasbeyer approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, lets see what CI tells us! 😆

@matthiasbeyer matthiasbeyer merged commit 47e1b7c into mehcode:master Dec 6, 2022
@matthiasbeyer
Copy link
Collaborator

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: gate async parts behind a feature flag?
2 participants
@nstinus @matthiasbeyer