Procedural macro for routing #19
Conversation
macros/Cargo.toml
Outdated
| workspace = ".." | ||
|
|
||
| [dependencies] | ||
| syn = {version="0.11.11", features=["full","parsing","printing"]} |
There was a problem hiding this comment.
Spaces should be before and after symbols. See https://github.com/rust-lang/crates.io/blob/master/Cargo.toml#L49 or https://github.com/rust-lang-nursery/rls/blob/master/Cargo.toml#L21 for some examples of what I mean.
macros/Cargo.toml
Outdated
| quote="0.3" | ||
|
|
||
| [lib] | ||
| proc-macro = true |
There was a problem hiding this comment.
Make sure and leave an empty line at the end of files. I wouldn't mind an .editorconfig like crates.io.
macros/src/lib.rs
Outdated
|
|
||
| fn impl_route_rewrite(meth: syn::Expr, opts: TokenStream, item: TokenStream) -> TokenStream { | ||
| let item = item.to_string(); | ||
| let item = syn::parse_item(&item).expect("Unable to parse item associated to get attribute"); |
There was a problem hiding this comment.
The std lib uses lowercase-without-punctuation for all error messages.
macros/src/lib.rs
Outdated
| let item = item.to_string(); | ||
| let item = syn::parse_item(&item).expect("Unable to parse item associated to get attribute"); | ||
|
|
||
| match &item.node { |
There was a problem hiding this comment.
warning: you don't need to add `&` to both the expression and the patterns
--> macros/src/lib.rs:25:5
|
25 | / match &item.node {
26 | | &syn::ItemKind::Fn(_, _, _, _, _, _) => {}
27 | | _ => panic!("get attribute is only for functions"),
28 | | }
| |_____^ help: try: `match item.node { .. }`
|
= note: #[warn(match_ref_pats)] on by default
Try running clippy over lib. Many of these warnings come up.
cargo +nightly-2017-08-30 clippy -p shio_macros --features nightly --all
Is how I run clippy. I pin a nightly version, install clippy, and then use it explicitly when I want it.
#[allow(non_camel_case_types)]
struct __shio_route_hello {
}
impl Clone for __shio_route_hello {
fn clone(&self) -> Self { *self }
}
impl Copy for __shio_route_hello { }
#[allow(non_upper_case_globals)]
static hello: __shio_route_hello = __shio_route_hello{};
impl Into<::shio::router::Route> for __shio_route_hello {
fn into(self) -> ::shio::router::Route {
(::shio::Method::Get, "/{name}", __shio_handler_hello).into()
}
}Neat solution to non-moveable statics with the newtype plus impl. I'd suggest shortening it up a bit with a ZST: #[allow(non_camel_case_types)]
struct hello;
impl Into<::shio::router::Route> for hello {
fn into(self) -> ::shio::router::Route {
(::shio::Method::Get, "/{name}", __shio_handler_hello).into()
}
} |
|
@Meralis40 Over all, nice work! Let's get this cleaned up a bit and we can merge it in. I'd love to see the "standard" methods before this is released though:
|
|
@mehcode All changes have been done, except complete clippy, because of "needless_pass_by_value" warning. Also, I've change the generated code as suggested & added the "standard" methods |
|
Rebased |
This is the first part for procedural macro for routing, very basic, only GET and POST.
This is currently nightly-only (relies on procedural macro attributes, not stable yet).
It's exposed into
shioandshio::preludeunder the nightly feature.See the
hello_macrosexamples for how to use it for get request.