Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add excluded vip support #114

Merged
merged 5 commits into from
Apr 19, 2023
Merged

feat: add excluded vip support #114

merged 5 commits into from
Apr 19, 2023

Conversation

dmachard
Copy link
Contributor

@dmachard dmachard commented Apr 5, 2023

This PR add a new metric keepalived_vrrp_excluded_state to follow excluded Virtual IPs as described in https://keepalived.readthedocs.io/en/latest/configuration_synopsis.html#vrrp-instance-definitions-synopsis

keepalived.data example:

------< VRRP Topology >------
 VRRP Instance = VI_IPV4
   VRRP Version = 2
   State = MASTER
   ....
   Virtual IP :
     10.0.0.2 dev ens224 scope global set
   Virtual IP Excluded :
     10.0.0.3 dev ens224 scope global set
   ...

@dmachard
Copy link
Contributor Author

Any chance to have a review on it ?

clwluvw
clwluvw requested changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@clwluvw clwluvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case?

@dmachard
Copy link
Contributor Author

new testcases added, ready for review

@dmachard dmachard requested a review from clwluvw April 18, 2023 19:12
clwluvw
clwluvw requested changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@clwluvw clwluvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please just add the Virtual IP Excluded to the 2.2.7 test file? They have the same style - It's kinda useless introducing a new test file for that.

@dmachard
Copy link
Contributor Author

done

@dmachard dmachard requested a review from clwluvw April 19, 2023 06:16
clwluvw
clwluvw approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@clwluvw clwluvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@clwluvw clwluvw merged commit df38644 into mehdy:master Apr 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clwluvw clwluvw clwluvw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmachard @clwluvw