Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make the order of execution simpler #132

Merged
merged 1 commit into from
Jul 23, 2023
Merged

refactor: make the order of execution simpler #132

merged 1 commit into from
Jul 23, 2023

Conversation

mehdy
Copy link
Owner

@mehdy mehdy commented Jul 23, 2023

No description provided.

@mehdy mehdy requested a review from clwluvw July 23, 2023 15:46
@mehdy
refactor: make the order of execution simpler
6db81a6 
Signed-off-by: Mehdi Khoshnoodi <mehdy.khoshnoody@gmail.com>
@mehdy mehdy requested a review from clwluvw July 23, 2023 16:21
clwluvw
clwluvw approved these changes Jul 23, 2023
View reviewed changes
Copy link
Collaborator

@clwluvw clwluvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn :)) pretty straightforward - not sure why I tried to save return stats, nil from duplication. Was an idiotic movement 😂

@clwluvw clwluvw merged commit 4d35cda into master Jul 23, 2023
6 checks passed
@clwluvw clwluvw deleted the refactor-simplifying branch July 23, 2023 16:23
@mehdy
Copy link
Owner Author

mehdy commented Jul 23, 2023

Damn :)) pretty straightforward - not sure why I tried to save return stats, nil from duplication. Was an idiotic movement 😂

It always happens when you look back at codes you've written before 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clwluvw clwluvw clwluvw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehdy @clwluvw