fix: add retry on errors for getKeepalivedStats #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clwluvw I'll clean up the other retry implementation if this is ok. |
Yes, it completely makes sense - we just need to remove the retry for file as we are already retrying on top of the func for every possible failure. |
clwluvw
reviewed
Jul 23, 2023
|
It actually makes a ton of sense :D |
mehdy
force-pushed
the
fix-115
branch
2 times, most recently
from
54839de
to
da00d0b
Compare
clwluvw
reviewed
Jul 23, 2023
clwluvw
reviewed
Jul 23, 2023
Signed-off-by: Mehdi Khoshnoodi <mehdy.khoshnoody@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
Closes #117 due to duplication