Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send signal for before getting script #138

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix: send signal for before getting script #138

merged 1 commit into from
Aug 3, 2023

Conversation

mehdy
Copy link
Owner

@mehdy mehdy commented Jul 30, 2023

Fixes #135

@mehdy mehdy added the bug Something isn't working label Jul 30, 2023
@mehdy mehdy requested a review from clwluvw July 30, 2023 12:36
clwluvw
clwluvw requested changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@clwluvw clwluvw left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already sending the signal in DataVrrps() - we only need to reorder the execution by first data and then the script in getKeepalivedStats() func or extract the signal call from the funcs.

@mehdy
Copy link
Owner Author

mehdy commented Jul 30, 2023

Yeah, I noticed. It's a bad idea that we rely on the order of execution. Each function should be able to respond correctly on its own.

@clwluvw
Copy link
Collaborator

clwluvw commented Jul 30, 2023 •
edited

Yeah, I noticed. It's a bad idea that we rely on the order of execution. Each function should be able to respond correctly on its own.

I guess we already tried to do that but the fact is the ScriptVrrps is relying on DataVrrps functionality - maybe it would make sense to mix ScriptVrrps and DataVrrps into a single func?
But still extracting the signal would make more sense I guess :))

@mehdy mehdy requested a review from clwluvw July 30, 2023 15:49
@mehdy
Copy link
Owner Author

mehdy commented Jul 30, 2023

Yes. I think this could be a better impl for now. Let me know what you think.

@mehdy
fix: separate refresh and getting data
2dc8d12 
Signed-off-by: Mehdi Khoshnoodi <mehdy.khoshnoody@gmail.com>
clwluvw
clwluvw approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@clwluvw clwluvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clwluvw clwluvw merged commit 558171b into master Aug 3, 2023
6 checks passed
@clwluvw clwluvw deleted the fix-135 branch August 3, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clwluvw clwluvw clwluvw approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/tmp/keepalived.data not created
2 participants
@mehdy @clwluvw