Changed getSiteLink to use protocol based on sslRequired variable. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrancodes
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
@gbradley Looks perfect! Now we have the getSiteLink fully test covered! 🙌
|
Test coverage!! 🥳 Thanks @gbradley. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
This PR ensures the site link that is added to comments uses the protocol expected by the user, based on the FORGE_SSL_REQUIRED environment variable.
The rationale for this approach is to ensure the URL is independent of any SSL provisioning process (which may be successful / pending / failed). This means users requesting a secure URL will never receive an insecure one, even if the SSL cert has not yet finished provisioning or there's some misconfiguration elsewhere.