Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility w/ TYPO3 v11.5-LTS #31

Closed
abeutel opened this issue Oct 5, 2021 · 4 comments · Fixed by #37
Closed

Compatibility w/ TYPO3 v11.5-LTS #31

abeutel opened this issue Oct 5, 2021 · 4 comments · Fixed by #37
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed next-release Planned for the upcoming release
Milestone

Comments

@abeutel
Copy link
Member

abeutel commented Oct 5, 2021

Provide version w/ basic compatibility

@abeutel abeutel added enhancement New feature or request help wanted Extra attention is needed labels Oct 5, 2021
@abeutel abeutel added this to the 1.x milestone Oct 5, 2021
abeutel added a commit that referenced this issue Oct 5, 2021
@someplace53
Copy link
Contributor

Not sure why I have not seen this issue before, but I created a fork where I switched to EventDispatcher. I mostly copied and reorganized the code. There are a few things which should probably change (e.g. the ResourceStorageException namespace) and I am open to suggestions. I only tested some basic functions, but it seems to work.

I did not change the NotifyCommand as I do not know why you are calling the Dispatcher there (I have never worked with signals and slots)

The switch from Command.php to Service.yaml should be easy as you are already using symphony commands. You need just add something like the following to the Service.yaml:

services:
  Mehrwert\FalQuota\Command\NotifyCommand:
    tags:
      - name: 'console.command'
        command: 'falquota:notifycommand'
        description: 'notify users for quota'
        hidden: false
        schedulable: true
  Mehrwert\FalQuota\Command\UpdateCommand:
    tags:
      - name: 'console.command'
        command: 'falquota:updatequota'
        description: 'update quota'
        hidden: false
        schedulable: true

The commands should now be listed as part as "Execute console command" in the scheduler

@someplace53
Copy link
Contributor

Okay, I introduced some bugs, but they should now be fixed. Some errors remain or might be in the current version:

  • event for beforeFolderCopied had a bug, which did not calculate the quota correctly (this should be a bug in the current version too), but was easily fixed
  • event for beforeFileReplaced shows an exception instead of the error message, but works otherwise
  • event for afterFileMoved did not update the source quota, fixed in my fork, but remains in the current version
  • event for afterFolderCopied does not update the quota and I have no idea why

Some events I am not sure how to test, as they imho should not change the quota (moveFolder, rename).

I hope this is helpful

@abeutel abeutel self-assigned this Jan 31, 2023
@abeutel abeutel added the next-release Planned for the upcoming release label Jan 31, 2023
@someplace53
Copy link
Contributor

The bugs mentioned above should be fixed. From my perspective this is done and I am already using it.

Should I create a pull request or what would you prefer?

@tstahn
Copy link
Contributor

tstahn commented Aug 10, 2023

Hi @someplace53, thanks for your effort! Please feel free to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed next-release Planned for the upcoming release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants