-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility w/ TYPO3 v11.5-LTS #31
Comments
Not sure why I have not seen this issue before, but I created a fork where I switched to EventDispatcher. I mostly copied and reorganized the code. There are a few things which should probably change (e.g. the I did not change the The switch from Command.php to Service.yaml should be easy as you are already using symphony commands. You need just add something like the following to the Service.yaml: services:
Mehrwert\FalQuota\Command\NotifyCommand:
tags:
- name: 'console.command'
command: 'falquota:notifycommand'
description: 'notify users for quota'
hidden: false
schedulable: true
Mehrwert\FalQuota\Command\UpdateCommand:
tags:
- name: 'console.command'
command: 'falquota:updatequota'
description: 'update quota'
hidden: false
schedulable: true The commands should now be listed as part as "Execute console command" in the scheduler |
Okay, I introduced some bugs, but they should now be fixed. Some errors remain or might be in the current version:
Some events I am not sure how to test, as they imho should not change the quota (moveFolder, rename). I hope this is helpful |
The bugs mentioned above should be fixed. From my perspective this is done and I am already using it. Should I create a pull request or what would you prefer? |
Hi @someplace53, thanks for your effort! Please feel free to create a PR. |
Provide version w/ basic compatibility
The text was updated successfully, but these errors were encountered: