[BUGFIX] Resolve dropped PATH_typo3 for TYPO3 10.x #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for contributing the fix, @alexander-nitsche ! Tested on 8.7 (+ELTS), 9.5 and 10.4 - approved and merged. |
This was referenced Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear mehrwert team,
your current version seems to fail to work in TYPO3 v10 as it requires the constant PATH_typo3 which has been dropped for TYPO3 v10. I added a switch and check that it works for TYPO3 v10.4.5 (did not check it for v8 and v9 though). Maybe you want to use it.
Greetings
Alex