Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifying reader attributes does not modify underlying tiff-class attributes #16

Closed
bryantChhun opened this issue May 18, 2021 · 1 comment

Comments

@bryantChhun
Copy link
Contributor

after building a reader:

mmr = MicromanagerReader(<folder to tiff files>)

modifying an attribute such as frames will not change the underlying tiff-class's attribute

mmr.frames = 10
print(mmr.reader.frames)
>>> not 10

This is a problem in cases where a acquisition quits before it's scheduled to finish -- so the metadata reflects a different dimensionality than actually exists. Simple case is when you specify a 100 frame time series at the start but end the collection after 50 frames.

Solution:
change reader attributes to getters/setters that modify and return the underlying tiff-type attribute

@bryantChhun
Copy link
Contributor Author

fixed in pr #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant