-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual attribute assignment #17
Conversation
Changing an attribute at the MicromanagerReader level doesn't propogate those changes down into the MicromanagerReader.reader level (the multipage tiff or singlepagetiff reader). I think these need to be propogated downward for the changes to have meaningful impact |
When I run the tests here it works. Adding new lines to force it to fail works too:
|
Weird, for some reason when I was doing it through the python console in pycharm it wasn't working. I ran your tests and tested it out in a notebook and it worked fine. Definitely a nice feature to have, thanks! |
Addresses issue #16
This PR simply enables the raw ability to modify the multipage/singlepage tiff class's dimensions from the reader.
Might enable us to manually adjust image dimensions for acquisitions that have been cut short. That condition requires additional testing.