Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Androminion in Android Studio #652

Closed
Kokyett opened this issue Jan 15, 2022 · 3 comments
Closed

Androminion in Android Studio #652

Kokyett opened this issue Jan 15, 2022 · 3 comments

Comments

@Kokyett
Copy link
Collaborator

Kokyett commented Jan 15, 2022

Hi.

I took the Menagerie branch and I've made some changes so the project can be build in Android Studio.

Main changes are:

  • Traget SDK is API levek 32 and min SDK version is 21.
  • ActionBarSherlock is replaced by androidx.AppCompat.
  • Logs, images are now stored in the application cache folder (until i manage permissions to write in external storage).
  • Images are downloaded using an http request instead of DownloadManager.
  • Settings are displayed in 4 tabs.
  • I've suppress all @SuppressWarning and @SuppressLint to study them and eventualy fix them.

Before doing a PR, I'd like to know if the project is dead and if it would accepted to miggrate to Android Studio an Gradle.

@dominionator
Copy link
Collaborator

@Kokyett Sounds like a great change overall. Thanks!

I've been lacking the time recently to make the updates I've wanted to.
Create the PR and I'll take a look.

I fully plan on finishing out the Menagerie branch and supporting Allies when it releases/ships in the coming weeks/months.

@Kokyett
Copy link
Collaborator Author

Kokyett commented Jan 18, 2022

@dominionator I'll prepare it this evening. If it is accepted, all others PR wont be easily merged as some files have been moved.

I have some ideas for the project:

  • notify when a new version had been released (using github release rss feed)
  • download card art image instead of full card image

@Kokyett
Copy link
Collaborator Author

Kokyett commented Jan 18, 2022

@dominionator PR is done.

It will be hard to check as a lot of files have been moved. I can publish a release on my fork if you want to test it.

@Kokyett Kokyett closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants