Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add GitHub pages style sheet #80

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

gene1wood
Copy link
Contributor

This was originally added in #35 but lost in e81d717 accidentally.

This style sheet does a few things

  • Changes the table height to 75% of the size of the viewport so you can see more rows
  • Sticky the header row and the left-most column so you can always see the photo library name and the attribute name while you scroll horizontally or vertically

This solves a few problems with the current table as viewed through GitHub's repo rendering of the readme.md

  • The horizontal scrollbar is only at the bottom of the table so you have to scroll to the bottom to scroll right and left at which point you can't see the table header showing the name of the photo library
  • When you scroll down the photo library name doesn't stay at the top of the table, it disappears

This PR also

  • Fixes a typo in the JSON config of markdown-link-check
  • Fixes a missing language for a code block in the readme
  • Fixes markdown link checker exceptions
  • Updates the lychee demo site URL

This was originally added in meichthys#35 but lost in e81d717 accidentally.

This style sheet does a few things

* Changes the table height to 75% of the size of the viewport so you can see more rows
* Sticky the header row and the left-most column so you can always see the photo library name and the attribute name while you scroll horizontally or vertically

This solves a few problems with the current table as viewed through GitHub's repo rendering of the `readme.md`

* The horizontal scrollbar is only at the bottom of the table so you have to scroll to the bottom to scroll right and left at which point you can't see the table header showing the name of the photo library
* When you scroll down the photo library name doesn't stay at the top of the table, it dissapears
This fixes a typo in the JSON config of markdown-link-check
and a missing language for a code block in the readme
The pigallery2.onrender.com demo URL changed, this accommodates that.
The SnapCrescent Demo site is serving up 503s (reported in snapcrescent/snapcrescent#52 ) so this disables link checking on it.
@meichthys
Copy link
Owner

Thanks @gene1wood. I appreciate this 👍

@meichthys meichthys merged commit 2e685f1 into meichthys:main Apr 8, 2024
1 check passed
@gene1wood gene1wood deleted the re-introduce-sticky-header branch April 8, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants