Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] no error or warning when jq is missing #169

Closed
legovaer opened this issue Sep 8, 2022 · 7 comments · Fixed by #171
Closed

[BUG] no error or warning when jq is missing #169

legovaer opened this issue Sep 8, 2022 · 7 comments · Fixed by #171
Assignees
Labels
bug Something isn't working

Comments

@legovaer
Copy link

legovaer commented Sep 8, 2022

Describe the bug
Runtipi expects jq to be installed on the host machine. Its however not raising an error if the bin does not exist.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repo on a host that does not have jq installed.
  2. Execute the start.sh script
  3. You will see a warning ./scripts/start.sh: line 123: jq: command not found

Expected behavior
The script should ask to install jq.

@legovaer legovaer added the bug Something isn't working label Sep 8, 2022
@legovaer legovaer changed the title [BUG] [BUG] no error or warning when jq is missing Sep 8, 2022
@justincmoy
Copy link
Contributor

It looks like configure.sh, called by start.sh, will install jq, but only if Docker is not installed.

@meienberger
Copy link
Collaborator

You are correct @justincmoy jq need to be installed also if docker is not present. @legovaer did you have docker installed prior to installation ?

@wax911
Copy link

wax911 commented Sep 11, 2022

I had docker installed prior, just had to manually add jq and rerun the script, I see that the PR has been merged but not on master yet so the error still exists

@meienberger
Copy link
Collaborator

@wax911 yes the bug has been fixed but I need to create a release soon to deploy it for everyone

@legovaer
Copy link
Author

You are correct @justincmoy jq need to be installed also if docker is not present. @legovaer did you have docker installed prior to installation ?

As mentioned above: I also had docker installed :)

@sethforprivacy
Copy link

sethforprivacy commented Sep 13, 2022

@legovaer this should be resolved in v0.6.1:

https://github.com/meienberger/runtipi/releases/tag/v0.6.1

Via this PR:

#171

@meienberger
Copy link
Collaborator

Fix has been released. Thanks @rblaine95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants