Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install jq if it's missing #171

Merged
merged 3 commits into from Sep 10, 2022
Merged

Install jq if it's missing #171

merged 3 commits into from Sep 10, 2022

Conversation

rblaine95
Copy link
Contributor

@rblaine95 rblaine95 commented Sep 9, 2022 •
edited

Check if JQ is installed.
If it's not, try and install it.

Closes #169

@meienberger
Copy link
Collaborator

Hello thanks for your pull request! We are further discussing in #169 if this can be solved by installing it instead of throwing an error if not there

@rblaine95 rblaine95 changed the title fix/Check if JQ is installed Install jq if it's missing Sep 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rblaine95
Copy link
Contributor Author

I noticed that the if statements in install_docker were using ${OS} instead of ${os} which caused the ifs to ignore the args which caused the failover sub_os to be ignored.

@meienberger
Copy link
Collaborator

You are correct! Nice catch

@runtipi runtipi deleted a comment from allcontributors bot Sep 10, 2022
@meienberger
Copy link
Collaborator

@all-contributors add @rblaine95 for code

@allcontributors allcontributors bot mentioned this pull request Sep 10, 2022
Merged
@allcontributors
Copy link
Contributor

@meienberger

I've put up a pull request to add @rblaine95! 🎉

@meienberger meienberger mentioned this pull request Sep 10, 2022
Closed
@meienberger meienberger changed the base branch from master to develop September 10, 2022 14:37
@meienberger meienberger merged commit 84360e7 into runtipi:develop Sep 10, 2022
@rblaine95 rblaine95 deleted the check-jq-installed branch September 10, 2022 15:07
@meienberger meienberger mentioned this pull request Sep 11, 2022
Merged
@sethforprivacy sethforprivacy mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] no error or warning when jq is missing
2 participants
@rblaine95 @meienberger