Skip to content

Commit

Permalink
change parameters type "LanguageCode" to "string"
Browse files Browse the repository at this point in the history
  • Loading branch information
meikidd committed Jun 10, 2022
1 parent 813f73d commit 3203f01
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,14 @@ declare module 'iso-639-1' {
| 'zu'

interface ISO6391 {
getName: (code: LanguageCode) => string;
getName: (code: string) => string;
getAllNames: () => Array<string>;
getNativeName: (code: LanguageCode) => string;
getNativeName: (code: string) => string;
getAllNativeNames: () => Array<string>;
getCode: (name: string) => LanguageCode;
getAllCodes: () => Array<LanguageCode>;
validate: (code: LanguageCode) => boolean;
getLanguages: (codes: Array<LanguageCode>) => Array<{
validate: (code: string) => boolean;
getLanguages: (codes: Array<string>) => Array<{
code: LanguageCode;
name: string;
nativeName: string;
Expand Down

1 comment on commit 3203f01

@Giildo
Copy link

@Giildo Giildo commented on 3203f01 Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if it breaks old usage, it's better!
It's ok for me, as long as we have the LanguageCode export ;)

Please sign in to comment.